[proposal] Allow 0 to be a valid UNIX timestamp.#1579
Open
falconscript wants to merge 2 commits intobalderdashy:masterfrom
Open
[proposal] Allow 0 to be a valid UNIX timestamp.#1579falconscript wants to merge 2 commits intobalderdashy:masterfrom
falconscript wants to merge 2 commits intobalderdashy:masterfrom
Conversation
Issuing console warnings for timestamp of 0 isn't necessary and are sometimes used to represent "unset" programmatically since datetimes must be type 'ref' and 'ref' cannot be null. Removing the if check will allow them to pass through in auto-migrations without spurring messages.
|
Hi @falconscript! It looks like your pull request title doesn’t quite conform to our guidelines. Please edit the title so that it starts with [proposal], [patch], [fixes #], or [implements #]. Once you've fixed it, post a comment below (e.g. "ok, fixed!") and we'll take a look! |
falconscript
changed the title
Author
|
[proposal] Added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issuing console warnings for timestamp of 0 isn't necessary and are sometimes used to represent "unset" programmatically since datetimes must be type 'ref' and 'ref' cannot be null. Removing the if check will allow them to pass through in auto-migrations without spurring messages.